Use single underscore for function/variables

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.

MIT License

766 stars 70 forks source link

Use single underscore for function/variables #113

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

Recently I've been thinking that most Fish plugins agree on using a single underscore for their "private" functions, while Fish exclusively uses two (except for _validate_int, which is being tackled with fish-shell/fish-shell#8168).

IMO it's worth it to be consistent with most Fish plugins out there.

franciscolourenco commented 2 years ago

@kidonng there is a small conflict which needs to be fixed before merging.