search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
766 stars 70 forks source link

Display tmux window ID in message if available #115

Closed Azenet closed 9 months ago

Azenet commented 2 years ago

This is a simple pull request for displaying the window ID in the message when a process ends and contains the appropriate environment variable.

franciscolourenco commented 2 years ago

@Azenet can you share an example of what this looks like in practice? Thanks!

Azenet commented 2 years ago

@franciscolourenco It adds [@2] at the beginning of the notification if the process was running in window 2, for example.

Azenet commented 2 years ago

I was using the wrong variable for the display, which became apparent after using tmux for a long time in which windows were closed (id stays unique). Also added a configuration variable for the format, defaults to [2] for window 2 for example.

Azenet commented 9 months ago

Sure, here is what the notification looks like after sleep 10 has ended in pane 30: Screenshot_20230927_025859

Rebased and made the requested change.

franciscolourenco commented 9 months ago

Thank you @Azenet! This will be released in v1.17.0.