Wrong parameter names in README

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.

MIT License

766 stars 70 forks source link

Wrong parameter names in README #119

Closed frazar closed 2 years ago

frazar commented 2 years ago

As of commit a2b53cb6efaab2cc24b3b8ae9498b6d4d6e8fc06, the name of all configuration variables use a single underscore as prefix rather than two. For example, __done_min_cmd_duration has become _done_min_cmd_duration.

However, the README has not been updated to reflect this change.

ammgws commented 2 years ago

Didn't realise there was such a breaking change lately! Should definitely be mentioned.. or perhaps reverted since not worth breaking everyone's config for it..

frazar commented 2 years ago

Yes, reverting sounds more reasonable