search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
770 stars 70 forks source link

Fix checks #13

Closed AaronLasseigne closed 7 years ago

AaronLasseigne commented 7 years ago

After a refactor, it looks like $argv was accidentally copied to a few places.

franciscolourenco commented 7 years ago

Wow, surprising it worked for me. Could you please

  1. Can you rename the _initial_window_id to __done_initial_window_id for namespace purposes?
  2. Capitalise the commits titles. (sorry for the lack of contribution guide)

Thanks

AaronLasseigne commented 7 years ago

Done