search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
766 stars 70 forks source link

macOS sound improvement #135

Closed jjanyan closed 9 months ago

jjanyan commented 1 year ago

I wanted to suggest a change the macOS sound notification to use the applescript notification instead of the terminal bell. It could also be upgraded to support different sounds.

            else if type -q osascript # AppleScript
                if test "$__done_notify_sound" -eq 1
                    osascript -e "display notification \"$message\" with title \"$title\" sound name \"Glass\""
                else
                    osascript -e "display notification \"$message\" with title \"$title\""
                end

I'm happy to send a PR over, but before I do, is this something you'd be interested in including?

smiller171 commented 1 year ago

Unfortunately it looks like @franciscolourenco isn't maintaining this anymore

franciscolourenco commented 1 year ago

I've not been spending much time with this project lately, but I will probably have more time moving forward. @jjanyan what you suggest makes sense, feel free to open a PR. Supporting multiple sounds however might be overkill, no?

jjanyan commented 1 year ago

PR created https://github.com/franciscolourenco/done/pull/136

franciscolourenco commented 9 months ago

Merged, thanks!. It will be released in v1.17.0