search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
766 stars 70 forks source link

Use kitty's new o=invisible option in notification protocol #142

Closed jinliu closed 7 months ago

jinliu commented 7 months ago

It's a new feature in Kitty 0.31 (which is just released). With that option, the notification is ignored if the window is focused and the tab is active, so we don't have to detect window state.

There's no reliable way to detect Kitty's version, so the user needs to set -U kitty_notification_unfocused 1.

jinliu commented 7 months ago

Closing this pull request. Since Kitty will have its own job notification feature in the upcoming release, now there's no point adding Kitty-specific integration, as a Kitty user probably won't use this plugin. Probably the merged https://github.com/franciscolourenco/done/pull/141 can be reverted, too.

franciscolourenco commented 7 months ago

@jinliu can you share information about this release? Thanks!

jinliu commented 7 months ago

The relevant option: https://github.com/kovidgoyal/kitty/blob/b961e65f2228ed957d17e2fd3b7a1c4b1c478fb1/kitty/options/definition.py#L3152 I don't know when will the next release be. You'll have to build it from source at the moment.