Specify whether the command finished successfully.

[skorokithakis]

Perhaps the notification can say whether the command finished with an error or successfully? This could be as simple as "Finished in X" and "Errored in X".

[franciscolourenco]

Good idea. Probably not "Errored' though.

"To use "errored" you would have to consider error a verb, but the dictionary doesn't. "Error" is a noun, used to mean mistake. You wouldn't say "The program mistaked at line 44." Your usage "threw an error" is correct, because it uses error as a noun."

[skorokithakis]

Yeah, I realized that as I was typing it, but all the alternatives felt worse. "Finished in X" "Finished with an error in X" is too long for the failure case, but maybe adding an extra line with "There was an error" at the end is good enough?

[franciscolourenco]

Finished in X with errors doesn't seem that long:

Other options would be Failed in X:

[jorgebucaran]

First one sounds more natural.

[skorokithakis]

Agreed, that seems fine to me too.

[franciscolourenco]

What do you guys think about Finished in 2m 32s vs Done in 2m 32s ?

First seems more natural but second is shorter and playful?

[jorgebucaran]

Definitely done.

[franciscolourenco]

And for errors?

😄

[franciscolourenco]

I wonder if Overdone after 2m 32s is clear enough or if Burned after 2m 32s would be better. Also we could add the exit code in case of error Overdone (1) after 2m 32s

[skorokithakis]

I think that's getting a bit too cryptic (not to mention that the metaphor doesn't work because the command took less time than it should :P).

[franciscolourenco]

hihi, so what, keep it to Done in X with errors?

[skorokithakis]

Sounds good to me, or "Finished with errors in X".

[franciscolourenco]

For errors ended up with something like Exit status 1 after 3m 23s.

Done in https://github.com/fisherman/done/releases/tag/1.2.0