franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
770 stars 70 forks source link

Threshold duration before notification #18

Closed franciscolourenco closed 6 years ago

franciscolourenco commented 7 years ago

I've been thinking about reducing the default minimum period a command needs to run in order to trigger a notification from 10s to 3s or 5s. Any scenarios where you think this would be undesirable?

dawehner commented 7 years ago

Works for me. My commands are mostly instant or long

dawehner commented 7 years ago

We should find out the average focus time of us using stats and set the time automatically ;(

franciscolourenco commented 7 years ago

The question is: if you switch away from the terminal to another app right after starting a command, and it finishes after 4s, would you not want to know about it? The notification never gets triggered as long as you are looking at the output of the command.

dawehner commented 7 years ago

Maybe it would be nice if the user didn't came back to the shell in a certain time. That's harder of course than just changing this time.

On Tue, 14 Feb 2017, 01:07 Francisco Lourenço, notifications@github.com wrote:

The question is: if you switch away from the terminal to another app right after starting a command, and it finishes after 4s, would you not want to know about it? The notification never gets triggered as long as you are looking at the output of the command.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/fisherman/done/issues/18#issuecomment-279575255, or mute the thread https://github.com/notifications/unsubscribe-auth/AABz7kFA6-NLYPqvkMQ65suexxB02Yeeks5rcP46gaJpZM4L-kEm .