franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
770 stars 70 forks source link

notify-send: set app-name and urgency #25

Closed joehillen closed 6 years ago

franciscolourenco commented 6 years ago

Can you please include a screenshot of what this looks like? Thank you

joehillen commented 6 years ago

I use dunst, so my setup is custom, but here you go: image

franciscolourenco commented 6 years ago

And what does it look like without app name?

joehillen commented 6 years ago

It's a 2 line patch. Do whatever you want

On Dec 3, 2017 1:15 PM, "Francisco Lourenço" notifications@github.com wrote:

@aristidesfl commented on this pull request.

In conf.d/done.fish https://github.com/fisherman/done/pull/25#discussion_r154536889:

@@ -69,7 +69,11 @@ and test -n __done_get_window_id # is able to get window id osascript -e "display notification \"$message\" with title \"$title\""

      else if type -q notify-send # Linux notify-send
  • notify-send --icon=terminal "$title" "$message"
  • set -l crit
  • if test $exit_status -ne 0
  • set crit "--urgency=critical"

$urgency would be easier to read

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fisherman/done/pull/25#pullrequestreview-80713601, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg5L-SKQJSpym5TE0tE5J9xPrQI-kPks5s8w9rgaJpZM4QzEz7 .