Closed grimpy closed 6 years ago
Rebased + reworked based on the previous comment
@grimpy thanks. is the idea to show a notification if the tmux window is not active ,or also if the window is active but not the pane?
Only when the window is not active, I'm assuming that one can always see all panes in the active window...
On Sun, 8 Apr 2018, 17:24 Francisco Lourenço, notifications@github.com wrote:
@grimpy https://github.com/grimpy thanks. is the idea to show a notification if the tmux window is not active ,or also if the window is active but not the pane?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/fisherman/done/pull/28#issuecomment-379558566, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIx_Q58Jo7quzxa1jby41OicmAXOzrHks5tmiuVgaJpZM4SJcy4 .
@grimpy thanks for the contribution <3 Did a bit of refactoring, could you please install done 1.7 and let me know if something is not working as expected? thank you!
@franciscolourenco I found some issues after this merge please check https://github.com/fisherman/done/pull/33 which I beleive fixes them
@grimpy Are you still using this plugin?
@ammgws I'm not even using fish atm
@grimpy You might remember that this script only sends notifications if the tmux window is inactive. In my case I also want it to send notifications when the session is detached, and am thinking about sending a PR for that. If you were still using fish with this plugin, would that have been a problem for your workflow?
It wouldn't and it sounds like a cool idea
Signed-off-by: Jo De Boeck deboeck.jo@gmail.com