franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
781 stars 71 forks source link

Fix tmux integration support #33

Closed grimpy closed 6 years ago

grimpy commented 6 years ago

Fix wrong method calls introduced in #9298e65dfee We want to check that our PID is in an attached tmux the window is NOT active, otherwise we have false postive when we have terminal with and withouth tmux running. Suppress tmux warning when no tmux server is running

Fixes: #32 #34

Signed-off-by: Jo De Boeck deboeck.jo@gmail.com

franciscolourenco commented 6 years ago

@grimpy thanks, last minute refactoring gone wrong. Going to trust that your PR works as expected since you are using tmux. Later we might want to use a better way to check if a tmux session exists instead of redirecting stderr. Thanks!