search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
781 stars 71 forks source link

Prompt stuck in Linux VT console #42

Closed yegorius closed 5 years ago

yegorius commented 5 years ago

Prompt hangs if fish is being run from Linux VT console. This happens because test -n __done_get_focused_window_id always evaluates to true, regardless of DISPLAY variable being set.

fregante commented 5 years ago

It's happening for me too:

macOS 10.14.3
fish, version 3.0.1
fisher version 3.2.7
terminal-notifier 1.8.0
franciscolourenco/done 1.7.3

❯ fisher ls
franciscolourenco/done
rafaelrinaldi/pure

I have to press ctrl+c to end it or click the notification, which makes this appear:

2019-03-29 10:55:48.460 terminal-notifier[29736:36262668] @CONTENTCLICKED

This actually seems to be a bug with terminal-notifier because after running brew uninstall terminal-notifier this bug no longer shows up.

yegorius commented 5 years ago

I know my fork is only relevant for Linux, but this is how I solved the problem in my case. https://github.com/yegorius/done

franciscolourenco commented 5 years ago

@fregante These seem to be separate issues then. @fregante would you mind creating a new ticket for the terminal-notifier problem so I can have a look into it separately?

@yegorius Thanks for the branch I will have a look!

franciscolourenco commented 5 years ago

@fregante have you tried updating terminal notifier? I have version 2.0 installed and cannot reproduce

franciscolourenco commented 5 years ago

@yegorius which distro are you using?

franciscolourenco commented 5 years ago

@yegorius I've pushed a fix. Could you please confirm that it works by uninstalling your fork and installing with 

fisher add franciscolourenco/done:fix-linux-vt

Thanks!

yegorius commented 5 years ago

It works ok, I am not experiencing the bug any more.

franciscolourenco commented 5 years ago

Released in 1.8.1

fisher remove franciscolourenco/done:fix-linux-vt
fisher add franciscolourenco/done