franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
770 stars 70 forks source link

Add support for windows #5

Closed franciscolourenco closed 4 years ago

franciscolourenco commented 7 years ago

@jbucaran any idea what people on windows are using to display notifications?

jorgebucaran commented 7 years ago

@aristidesfl Not sure, but these couple of hits seem promising.

franciscolourenco commented 7 years ago

@jbucaran do you have any stats on the percentage of users on Windows? Trying to evaluate if it would be worthwhile to work on this since I never use windows.

jorgebucaran commented 7 years ago

Definitely low. I think you can keep the issue open, but not make it a priority?

zhangnew commented 5 years ago

For wsl : https://github.com/Microsoft/WSL/issues/2466

PS C:\WINDOWS\system32> Install-Module -Name BurntToast

set -U __done_notification_command 'powershell.exe -command New-BurntToastNotification -Text WSL-ok'

franciscolourenco commented 5 years ago

@zhangnew do you have a proposal on how to integrate this in the package?

6A61736F6E206E61646572 commented 4 years ago

If being run under WSL:

However the biggest issue is detecting whether or not the terminal window is in the foreground.

ammgws commented 4 years ago

AFAIK when running on Windows, fish would just be running in something like cygwin or WSL where you cannot get the focused state of the app. However since this script also seems to work with tmux, perhaps on Windows notifications could still be sent when using tmux.

I don't seem to be getting any notifications from detached tmux windows on my linux machine, so first I will debug that and once it is working I will check using Windows and if successful can submit a PR for (limited) Windows support.

ammgws commented 4 years ago

Solved with #60.