Closed franciscolourenco closed 4 years ago
@aristidesfl Not sure, but these couple of hits seem promising.
@jbucaran do you have any stats on the percentage of users on Windows? Trying to evaluate if it would be worthwhile to work on this since I never use windows.
Definitely low. I think you can keep the issue open, but not make it a priority?
For wsl : https://github.com/Microsoft/WSL/issues/2466
PS C:\WINDOWS\system32> Install-Module -Name BurntToast
set -U __done_notification_command 'powershell.exe -command New-BurntToastNotification -Text WSL-ok'
@zhangnew do you have a proposal on how to integrate this in the package?
If being run under WSL:
grep Microsoft /proc/version
powershell.exe -command Get-Module -Name BurntToast
. (Need to figure out how to get the exit status from this command...)However the biggest issue is detecting whether or not the terminal window is in the foreground.
AFAIK when running on Windows, fish
would just be running in something like cygwin or WSL where you cannot get the focused state of the app. However since this script also seems to work with tmux
, perhaps on Windows notifications could still be sent when using tmux.
I don't seem to be getting any notifications from detached tmux windows on my linux machine, so first I will debug that and once it is working I will check using Windows and if successful can submit a PR for (limited) Windows support.
Solved with #60.
@jbucaran any idea what people on windows are using to display notifications?