search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
767 stars 70 forks source link

Quote arguments for `test` command #57

Closed ammgws closed 4 years ago

ammgws commented 4 years ago

  1. Quoted the arguments to the test commands used in the code to adhere to best practice.

    Since it is always safe to enclose variables in double-quotes when used as test arguments that is the recommended practice.

  2. Add -n argument as we want to check that the variable is "defined and not empty".

franciscolourenco commented 4 years ago

Thank you!