franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
767 stars 70 forks source link

done.fish invokes the ImageMagick import utility and break everything #74

Closed RaitoBezarius closed 4 years ago

RaitoBezarius commented 4 years ago

Hi there, thank you for your work!

Since the latest version 1.14.1, it seems like done.fish is invoking import somewhere and import is also known as an ImageMagick tool, blocking the shell, waiting for a GUI input.

I'm not sure if it's related to PowerShell addition because of Import-Module or something like this.

Can I give you some help to find this?

Thanks!

ammgws commented 4 years ago

If you have fish 3.1, does setting fish_trace to 1 show any useful output?

ammgws commented 4 years ago

Actually are you sure it's not the same as this issue:

https://github.com/franciscolourenco/done/commit/5d7f6ae50a9e8c7d1c95af5ad8bfc3155b331fbc#commitcomment-38204903

?

RaitoBezarius commented 4 years ago

@ammgws Oh, it is the same, most likely indeed.

ammgws commented 4 years ago

@RaitoBezarius The latest release should have fixed this, can you confirm?

RaitoBezarius commented 4 years ago

@ammgws Tested, it works!