WSL support improvements

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.

MIT License

767 stars 70 forks source link

WSL support improvements #79

Closed eugene-babichenko closed 4 years ago

eugene-babichenko commented 4 years ago

Implement __done_get_focused_window_id on WSL as a PowerShell script.
Replace command "$powershell_exe" with eval because a variable cannot be used as a command path.
Use the -Silent option of BurntToast when __done_notify_sound is set to zero.

franciscolourenco commented 4 years ago

@eugene-babichenko thank you for the PR. @ammgws do you have windows setup handy to test this? would be nice to have at least a 2nd person testing before publishing. thanks!

ammgws commented 4 years ago

@franciscolourenco I should be able to get access to a windows machine sometime this week.

ammgws commented 4 years ago

OK so it looks like the window state detection is working fine (doesn't notify if window is focused), however notifications aren't working:

I'm guessing it's because the variables to BurntToast aren't being expanded due to the code block being in single quotes.

ammgws commented 4 years ago

Can confirm it works when fixed to use double quotes.

franciscolourenco commented 4 years ago

Thank you for the awesome contribution!