search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
779 stars 71 forks source link

generate notifications on WSL without using BurntToast #90

Closed eugene-babichenko closed 3 years ago

franciscolourenco commented 4 years ago

Thank you @eugene-babichenko! Is there any compatibility issues for existing users? Would it make sense to still support BurnToast for users who have it installed, but not wslu?

Anyone else on Windows can confirm that this is working?

eugene-babichenko commented 4 years ago

@franciscolourenco

Is there any compatibility issues for existing users?

No. We just don't use BurntToast anymore, it do not add any new dependencies or incompatible configuration changes.

Would it make sense to still support BurnToast for users who have it installed, but not wslu?

Hm, I don't understand this question. wslu already was a requirement because it was used to launch powershell scripts.

meatcar commented 4 years ago

Tested, works on Ubuntu under WSL2.

As for the wslu dependency, its preinstalled on Fedora Remix, Pengwin, and Ubuntu distros as per wslu README. We only use it after checking if it's available, it isn't a hard dependency currently.