search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
767 stars 70 forks source link

Fisher 4.x #93

Closed jorgebucaran closed 3 years ago

jorgebucaran commented 3 years ago

Fisher >=4.0 uses install now.

franciscolourenco commented 3 years ago

I assume it is backwards compatible?

jorgebucaran commented 3 years ago

@franciscolourenco add still works, but prints a deprecation warning. I'll completely remove it in the next major release. Or do you mean something else?

Don't know what I was thinking. It used to print a deprecation warning, but it prints an error now.

franciscolourenco commented 3 years ago

I meant – does fish install already work in fish v3?

franciscolourenco commented 3 years ago

So the new instructions are incompatible with fisher 3? Will fisher update automatically?

jorgebucaran commented 3 years ago

So the new instructions are incompatible with fisher 3?

Yes.

Will fisher update automatically?

No, existing users will upgrade to 4.x by running fisher self-update.

Related: Fisher 4 Release Notes

jorgebucaran commented 3 years ago

@franciscolourenco Do you need anything else here?

franciscolourenco commented 3 years ago

No was just concerned that users with fisher v3 won't be able to install. Thank you for the pull request! ❤️

jorgebucaran commented 3 years ago

Since Fisher will print an error, I think users will probably come knocking at my door first (if they can't figure out how to upgrade). We'll see. Thanks!