search

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.
MIT License
766 stars 70 forks source link

iTerm2 '__done_initial_window_id' set to 'com.googlecode.iterm2' instead of 'iTerm2' #98

Closed JLLeitschuh closed 9 months ago

JLLeitschuh commented 3 years ago

When I run terminal-notifier -message "Test" -sender "$__done_initial_window_id" this does not work. However when I run terminal-notifier -message "Test" -sender "iTerm2" this works. It looks like __done_initial_window_id is being set to com.googlecode.iterm2.

JLLeitschuh commented 3 years ago

End result is no notification is generated due to this issue

franciscolourenco commented 3 years ago

What version of macOS, iTerm and done are you using?

franciscolourenco commented 3 years ago

com.googlecode.iterm2 works correctly in my machine and displays the right iTerm2 icon. iTerm2 doesn't seem to work.

JLLeitschuh commented 3 years ago 
  System Version:   macOS 10.15.7 (19H114)
  Kernel Version:   Darwin 19.6.0

iTerm Build 3.4.3

I also see the same issue with the terminal from IntelliJ IDEA.

franciscolourenco commented 3 years ago

Do you have notifications allowed for iTerm app? image

franciscolourenco commented 3 years ago

And when you trigger a notification with -sender iTerm2, does it have the iTerm icon in the notification?

EddieEldridge commented 2 years ago

Do you have notifications allowed for iTerm app? image

Thank you, this was my issue and it is now resolved 👍

franciscolourenco commented 9 months ago

Marking this as fixed. @JLLeitschuh let me know if you still have this problem.