search

franciscop / server

:desktop_computer: Simple and powerful server for Node.js
https://serverjs.io/
MIT License
3.56k stars 171 forks source link

socket.io-client with only websocket transport blows up server.js session module #106

Closed paulrobello closed 5 years ago

paulrobello commented 5 years ago

server version 1.0.18 socket.io version 2.1.0

browser client: io('localhost:1977', {transports: ['websocket']})

server.js exception TypeError: argument res is required TypeError: argument res is required at onHeaders (.\node_modules\on-headers\index.js:25:11) at session (.\node_modules\express-session\index.js:219:5) at Array. (.\node_modules\server\plugins\session\index.js:44:7) at run (.\node_modules\socket.io\lib\namespace.js:124:11) at Namespace.run (.\node_modules\socket.io\lib\namespace.js:136:3) at Namespace.add (.\node_modules\socket.io\lib\namespace.js:164:8) at Client.doConnect (.\node_modules\socket.io\lib\client.js:97:20) at Client.connect (.\node_modules\socket.io\lib\client.js:66:17) at Server.onconnection (.\node_modules\socket.io\lib\index.js:434:10) at Server.emit (events.js:182:13)

franciscop commented 5 years ago

Same thing here as in https://github.com/franciscop/server/issues/105

Since I started working fulltime my time/energy for OSS has decreased greatly. Sorry for leaving you hanging, I've been wanting to write about this for a while.