search

franciscop / server

:desktop_computer: Simple and powerful server for Node.js
https://serverjs.io/
MIT License
3.56k stars 170 forks source link

Dependencies Update #143

Closed kinostl closed 1 year ago

kinostl commented 1 year ago

I haven't actually tested this beyond a simple hello world with redis enabled. Just thought I'd start the conversation while I fix the automated tests and get some guidance on how to test it properly.

ioredis looked more confident in itself in the connect-redis docs than node-redis so I went with that.

kinostl commented 1 year ago

Anything reliant on errors.js is failing because I did not update for Log correctly and I cannot figure out how to properly replicate what is desired for the report configuration option.

Also, log functionality does not actually work.

kinostl commented 1 year ago

Closing in favor of https://github.com/franciscop/server/pull/144

franciscop commented 1 year ago

BTW now I think it was a mistake to include log in the core, but don't want to remove it all and make a major just because of that, for your own code I'd recommend just using a logging utility as you would usually.