francisdb / movie-browser

Automatically exported from code.google.com/p/movie-browser
0 stars 0 forks source link

Renaming a Movie #67

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Rename a movie and then select No when it asks to cache new details. Then
close the app and open it again and you'll see that the renamed movie will
change according to the folder name. 

While if we use the rename function with a correct movie name, you won't
see this problem, so I don't know if this issue needs fixing. 

Original issue reported on code.google.com by ravi.und...@gmail.com on 17 Aug 2008 at 5:10

GoogleCodeExporter commented 9 years ago
think i fixed this, maybe it would be better to have a checkbox in the rename 
dialog
for the reload instead of a second dialog

you can trigger an update using movieInfo.triggerUpdate();

Original comment by franci...@gmail.com on 17 Aug 2008 at 8:50

GoogleCodeExporter commented 9 years ago
Added check box and got rid of second dialog as of r449

Original comment by ravi.und...@gmail.com on 18 Sep 2008 at 3:44

GoogleCodeExporter commented 9 years ago
movieInfo.triggerUpdate(); doesn't seem to work. 
Please take a look at code in MainFrame under rename option. I've tried the 
following
methods to trigger a re-caching after a rename: 

// unlink the file from the movie
    info.getMovieFile().setMovie(null);
    browser.getMovieCache().update(info.getMovieFile());
// request reload
    browser.getMovieFinder().reloadMovie(info);

Original comment by ravi.und...@gmail.com on 18 Sep 2008 at 3:50

GoogleCodeExporter commented 9 years ago
need to discuss this since the movie folder is not visisble any more (only 
title)
and a movie can now be linked to multiple files/folders

Original comment by franci...@gmail.com on 22 Sep 2008 at 9:17

GoogleCodeExporter commented 9 years ago
gzsombor please let us know what you think about this

Original comment by franci...@gmail.com on 22 Sep 2008 at 9:18

GoogleCodeExporter commented 9 years ago
Since it scans the directories once before it builds information, maybe we could
change the directory name during that process if the user has setup movie 
browser to
change the directory name to the imdb title. 

Original comment by ravi.und...@gmail.com on 22 Sep 2008 at 3:09

GoogleCodeExporter commented 9 years ago
but there is no guarantee that the title detection/lookup is correct...

Original comment by franci...@gmail.com on 22 Sep 2008 at 3:11

GoogleCodeExporter commented 9 years ago
This renaming stuff is not clear for me. What do you want to rename ? The
folder/file? It won't be too obvious which one. Or the guessed movie title ?
 Last time I've checked, the following scenario worked: 
1, scan the directory
2, it detects some incorrect movie title
3, enter a new name for the movie
4, and it automaticly refresh the values from imdb & co.

Original comment by gzsom...@gmail.com on 22 Sep 2008 at 4:11

GoogleCodeExporter commented 9 years ago
The renaming is for the directories the movie file is kept in. 

For example:

Pulp-Fiction-Movie-xvid-HiTTS-aXXo
--cd1
----cd1.avi
--cd2
----cd2.avi

Since the folder is Pulp-Fiction-xvid-HiTTS-aXXo and the we detect the movie 
with
title Pulp Fiction, the folder Pulp-Fiction-xvid-HiTTS-aXXo should be renamed 
to Pulp
Fiction.

I still haven't seen the new refactored code. I'll take a look at it this 
weekend and
see what I can do. Some tips from you would be helpful though. 

Original comment by ravi.und...@gmail.com on 24 Sep 2008 at 10:29