search

franciskafieh / obsidian-list-modified

🪨 The advanced and adaptive changelog for Obsidian. Links all modified files meeting certain criteria to a timed (daily, weekly, monthly) note.
MIT License
85 stars 7 forks source link

Possible more inclusive vocab than blacklist #11

Closed claremacrae closed 2 years ago

claremacrae commented 2 years ago

In case you are open to an alternative word to blacklist, here are some suggestions:

https://english.stackexchange.com/questions/51088/alternative-terms-to-blacklist-and-whitelist

franciskafieh commented 2 years ago

sorry, i had no intentions to discriminate! will probably change to 'blocklist.' does that sound good?

claremacrae commented 2 years ago

sorry, i had no intentions to discriminate!

Great - I had a feeling that would be the case!

will probably change to 'blocklist.' does that sound good?

It's definitely mentioned in multiple answers on that stack exchange question.

I slightly wonder if it's open to misreading as blacklist, with only one char different - and maybe 'blocked list' might be clearer - but don't feel that strongly. Totally up to you!

claremacrae commented 2 years ago

Another alternative might be to go for a more descriptive word or phrase altogether...

For example, "tags to ignore" - or "tags that will not be linked".

franciskafieh commented 2 years ago

sorry, i had no intentions to discriminate!

Great - I had a feeling that would be the case!

will probably change to 'blocklist.' does that sound good?

It's definitely mentioned in multiple answers on that stack exchange question.

I slightly wonder if it's open to misreading as blacklist, with only one char different - and maybe 'blocked list' might be clearer - but don't feel that strongly. Totally up to you!

what about simply 'ignored tags'?

inb4 lol, just saw your message appear

edit: will change to 'ignored tags'

franciskafieh commented 2 years ago

Done! See https://github.com/franciskafieh/obsidian-list-modified/commit/68df6459228128eae754f68190b430c30e16b76f and https://github.com/franciskafieh/obsidian-list-modified/commit/e3f5e1753e6f11fdb6009e623f33edd90b5b7d3f

claremacrae commented 2 years ago

Done! See 68df645 and e3f5e17

Wow, that was quick. Very many thanks for doing this, I really appreciate the kindness! ❤️

claremacrae commented 2 years ago

@franciskafieh I was curious that there were no visible UI changes, so did a search and found this:

https://github.com/franciskafieh/obsidian-list-modified/blob/master/src/settings.ts#L66

    .setName("Blacklisted Tags")
franciskafieh commented 2 years ago

@franciskafieh I was curious that there were no visible UI changes, so did a search and found this:

https://github.com/franciskafieh/obsidian-list-modified/blob/master/src/settings.ts#L66

    .setName("Blacklisted Tags")

Argh! I missed that! let me fix right now :)

franciskafieh commented 2 years ago

image Nevermind, I had gotten it. Vscode/git are being weird. It isn't tracking my changes.... Going to try to fix that

franciskafieh commented 2 years ago

Seems like it's an issue with using git from wsl.... Just going to force git to track changes for now.

here we go! https://github.com/franciskafieh/obsidian-list-modified/commit/e08f57cc3915c9c0dac50143ffd6145c9035b204

edit: feel free to re-open the issue if i missed something else 😭

claremacrae commented 2 years ago

Seems like it's an issue with using git from wsl.... Just going to force git to track changes for now.

here we go! e08f57c

That's a very weird commit. It shows every single line as changed...

edit: feel free to re-open the issue if i missed something else 😭

:-)