franciskafieh / obsidian-list-modified

🪨 The advanced and adaptive changelog for Obsidian. Links all modified files meeting certain criteria to a timed (daily, weekly, monthly) note.
MIT License
85 stars 7 forks source link

Heading reverts to default if not found in file #55

Closed franciskafieh closed 1 year ago

franciskafieh commented 1 year ago

Maybe one more piece of feedback: I expected that if I change the "Heading" setting, when there is no appropriate section in the daily note, the "default" value will be created using my configuration. But I was wrong, and every time the plugin does not detect the specified Heading, it re-creates the default "(h1) Modified Today" and reverts my configuration back to the default value.

Originally posted by @sotakal in https://github.com/franciskafieh/obsidian-list-modified/issues/54#issuecomment-1302349563

franciskafieh commented 1 year ago

Going to work on getting this fixed for 2.1 (by October 13th for Obsidian October!) Just very busy atm

franciskafieh commented 1 year ago

Was not able to finish on time :(

Also realized that my current 2.0.2 pre-release is super buggy, so I'm not going to submit that either. I'm "finished" 2.1, but there remain a bunch of unexpected bugs I have to tackle, so it might take me a few for days to finish

JoelAnderson-UU commented 1 year ago

Hang in there! This is a very, very handy plugin, and I'm really keen to use a stable version of 2.0!

MMoMM-org commented 1 year ago

to add to the issue.. the plugin is really spammy if this is the case. I'm not able to create my daily note without it at least spamming 20 times that the header doesn't exists after starting Obsidian or switching over to Obsidian on the next date. As I have to enter some information manually into my daily note I can't autocreate it.

franciskafieh commented 1 year ago

to add to the issue.. the plugin is really spammy if this is the case. I'm not able to create my daily note without it at least spamming 20 times that the header doesn't exists after starting Obsidian or switching over to Obsidian on the next date. As I have to enter some information manually into my daily note I can't autocreate it.

Honestly, I think I'm just going to remove this notice or have it run once on startup.

MMoMM-org commented 1 year ago

I think you should wait some time after startup.. perhaps have an initial 5 minute wait? Also I have configured the write interval to 30.. so it really shouldn't spam that much.

franciskafieh commented 1 year ago

Yes, gotta fix that, too. I think it was fixed in 2.1 because I re-wrote the interval system, but now it's gone and I need to get to writing it again

setu4993 commented 1 year ago

Still seeing this in v2.0.1 (current latest). Curious what the timeline on the fix / release for this is?

franciskafieh commented 1 year ago

2.0.2 should be latest, but that's irrelevant because it did not fix this issue. Honestly, I've just been busy with school and other projects. To add to that, I'm feeling demotivated because I was almost finished 2.1 (a big release that would've fixed this issue amongst others) and then it was wiped from my computer. Sorry for the delay to anyone waiting, but I promise I will get it done eventually.

The reason 2.1 did (and will) take a long time is because I need to find a good mechanism for created and deleted files (new addition in this version). Hopefully I can get started on fixing it this week.

setu4993 commented 1 year ago

Thanks for that context, @franciskafieh. I totally understand how hard it is to start working on a project again after a data loss.

I'm not a NodeJS dev by any means, but I have dabbled a bit in TS. If you can point me in the approx direction for where to look to fix this, I can try to help fix atleast this issue.

The rest of the v2.1 release sounds useful! And good luck with school!

franciskafieh commented 1 year ago

Nah it's alright. Fixing this sole issue I could do pretty quick myself, but thanks for offering! If you'd like, I could release a minor fix just for this instead of waiting until 2.1 ---- On Thu, 29 Dec 2022 16:25:09 -0500 @.*** wrote ---- Thanks for that context, @franciskafieh. I totally understand how hard it is to start working on a project again after a data loss. I'm not a NodeJS dev by any means, but I have dabbled a bit in TS. If you can point me in the approx direction for where to look to fix this, I can try to help fix atleast this issue. The rest of the v2.1 release sounds useful!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

setu4993 commented 1 year ago

I don't mind waiting for v2.1. Whichever way works best for you.

Thanks, @franciskafieh!

franciskafieh commented 1 year ago

Just got back from the mall, going to publish a super quick and dirty fix that should fix this issue temporarily until the re-write in 2.1

franciskafieh commented 1 year ago

Release 2.0.3 should fix the original bug. Please re-open if not.

setu4993 commented 1 year ago

Wow, didn't expect this to be done so fast. Thanks a bunch, @franciskafieh!