search

francislavoie / gnome-shell-volume-scroller

GNOME Shell Extension for adjusting volume with a mouse wheel
https://extensions.gnome.org/extension/5904/volume-scroller/
GNU General Public License v2.0
6 stars 3 forks source link

Revert latest PR & Add "Invert Direction" setting in the extension settings. #10

Closed salihefee closed 3 months ago

salihefee commented 3 months ago

I apologize again for the latest PR. This reverts the changes made in the latest PR and adds an option to invert the direction.

francislavoie commented 3 months ago

I think this'll still invert for both input methods since it doesn't do any input detection on the scroll event. So users might need to toggle the setting by hand if they plug in a mouse or w/e. Not perfect, but probably good enough for 99.9% of users :sweat_smile:

salihefee commented 3 months ago

Yes it will invert for both methods but I don't think there is an easy way of getting the source device, so this is the best I can do. Yes, it is not perfect, but at least now users have an option to invert whereas before, they would have to edit the extension source everytime they change the device :)

francislavoie commented 3 months ago

FYI, for next time, you shouldn't commit on your main branch because it causes weird conflicts. You should instead make a new branch on your own repo based on upstream's main and then make your commits on that. Your main is behind my main so this PR has repeated commits which isn't ideal. But it's fine, I can resolve it :+1:

Also, best practice is to put a reference to the relevant issue in the PR description (i.e. #7) to link them together

salihefee commented 3 months ago

I'm sorry, these two are my first pull requests and I am not experienced with git + development in general. I will keep that in mind the next time I create a PR. Thank you.

francislavoie commented 3 months ago

No need to be sorry :) you're doing great!