search

francislavoie / gnome-shell-volume-scroller

GNOME Shell Extension for adjusting volume with a mouse wheel
https://extensions.gnome.org/extension/5904/volume-scroller/
GNU General Public License v2.0
6 stars 3 forks source link

Fixed natural scrolling bug #9

Closed salihefee closed 3 months ago

salihefee commented 3 months ago

Used the Gio.Settings API to query the natural-scroll option and inverted scrolling accordingly.

salihefee commented 3 months ago

Just a comment; also did you build and test this locally? Did you try without natural turned on as well?

Yes, it works with natural scrolling on and off.

francislavoie commented 3 months ago

Oh - I guess this assumes all scroll events come from the trackpad? What if a user uses a mouse instead but has natural enabled? It might flip how the mouse behaves I think.

salihefee commented 3 months ago

Oh - I guess this assumes all scroll events come from the trackpad? What if a user uses a mouse instead but has natural enabled? It might flip how the mouse behaves I think.

Oh my god... I don't know how I didn't realise that. I am discarding this and I will create another PR with an "Invert Direction" settings added. I am so sorry.

francislavoie commented 3 months ago

I think it might be possible to check the source of the scroll event though. You could experiment with that.