search

francisyzy / pe

0 stars 0 forks source link

NRIC Checksum number does not work #2

Open francisyzy opened 1 year ago

francisyzy commented 1 year ago

If I typo and entered the wrong last character or any wrong character in the NRIC field, the system does not prompt me and let me know that the NRIC I've entered is wrong based on the checksum alphabet.

add_elderly n/Betsy Crowe p/98765432 a/John street ic/S5034567C bd/1950-02-03

add_elderly n/Betsy Crowe p/98765432 a/John street ic/S5034567D bd/1950-02-03

Both these NRIC Fields are correct whereas the checksum for one of them is definitely wrong. IF S5034567C is a valid NRIC, then S5034567D definitely isnt.

image.png

nus-pe-bot commented 1 year ago

Team's Response

image.png

This is our current NRIC section in the UG. As suggested by the last line, we do not validate birthdates against NRIC, nor its checksum.

Given that we have implemented the checks to ensure that NRIC begins and ends with letters and contains 7 digits, we feel that further checking for checksum is of lower priority in v1.4

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]