search

francisyzy / pe

0 stars 0 forks source link

Birthdate past checker. #5

Open francisyzy opened 1 year ago

francisyzy commented 1 year ago

I can add someone that is very old, probably too old to be living still.

image.png

nus-pe-script commented 1 year ago

Team's Response

We feel that since we already implemented a edit feature, users can amend the birthdate if it was entered incorrectly

Given the other work we have accomplished, we feel that restricting the age does not provide high value to the user as of v1.4.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Allows adding a person with too high ages & zero

image.png

It might be better to set a maxium value for an age. Although it is a valid date, it allows entering year 0000.

Age of too high value is also in the UG screenshot, but I think it is better to avoid having it. (Showing error message when a person is too old (older than 150 yrs) or too young (0 yr old))

[original: nus-cs2103-AY2223S2/pe-interim#4560] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We feel that since we already implemented a edit feature, users can amend the birthdate if it was entered incorrectly

Given the other work we have accomplished, we feel that restricting the age does not provide high value to the user as of v1.4.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]