Net cdf encoder set dimensions02

franckalbinet / marisco

Encoding IAEA MARIS data as NetCDF and others.

https://fr.anckalbi.net/marisco/

Apache License 2.0

3 stars 1 forks source link

Net cdf encoder set dimensions02 #10

Closed niallmurphy93 closed 3 months ago

niallmurphy93 commented 3 months ago

I updated the NetCDFEncoder in serializers.ipynb to use the dimensions of the group. Before the OSPAR biota netcdf data had the dimension the same as the seawater dataset, see below.

With this update the dimensions of the OSPAR biota netcdf are as expected, see below.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

franckalbinet commented 3 months ago

The NetCDF dimension is currently 'sample' defined at root level and shared by all groups. But I might misunderstand your point. Let's clarify it later today.