franckverrot / activevalidators

Collection of ActiveModel/ActiveRecord validators
https://rubygems.org/gems/activevalidators
MIT License
306 stars 49 forks source link

SIN Validator not handling 000 000 000 #104

Closed DanGodfrey closed 5 years ago

DanGodfrey commented 6 years ago

A value of 000 000 000 will currently pass validation as it is a valid Luhn number but not a valid SIN.

franckverrot commented 6 years ago

Hey @DanGodfrey, would you like to take a stab at it or should I go ahead and do it?

Thanks for reporting this!

franckverrot commented 5 years ago

Fixed by https://github.com/franckverrot/activevalidators/commit/61ab1e63714df083564ae6d7219151d7707f7e39