credit card validation

[Fivell]

I think credit card validation is out of date, also it have not all needed features. Is there a chance to merge activevalidators with https://github.com/Fivell/credit_card_validations gem? Or I can create pull request with some kind of wrapper .

[franckverrot]

Hi there,

I think credit card validation is out of date, also it have not all needed features.

Has anything changed? I'm not sure what you're referring to. What features are we talking about?

I can create pull request with some kind of wrapper

I think I wouldn't pull the core extensions. I don't wanna mess with String. I was also thinking about extracting the logic into dependency-free classes and make AV be the glue between them and ActiveModel/ActiveRecord. I started last week but it's gonna take me a while to complete it as I'm pretty busy those days.

Thanks!

[Fivell]

Hi @franckverrot ! Let me explain . brands :carte_blanche, :en_route doesn't exist any more, I think it's diners club now, also there is no algorithm of checking some of brands (maestro, unionpay ..) . Also AV provides regular expressions not for all credit card brands, for some brands there is only luhn check, but luhn validation is not enough for detecting credit card brand. There is no core-extensions required by default in credit_card_validations, you can require it only if you want.

[franckverrot]

Hi there,

Do you still wanna make the integration of your gem in AV? I'm sorry I couldn't get back to you sooner, but my schedule went a little bit crazy :-(

Anyways, tell me if you want to do it, and I can give you guidance.

Thanks!

[Fivell]

Hi, @franckverrot , have the same story with my schedule, please review PR

[franckverrot]

Awesome!