search

franckverrot / activevalidators

Collection of ActiveModel/ActiveRecord validators
https://rubygems.org/gems/activevalidators
MIT License
306 stars 49 forks source link

Providing {:type => :usa_ssn} is deprecated and will be removed in the future. Please use `:ssn => true` instead. #68

Closed Loremaster closed 10 years ago

Loremaster commented 10 years ago

I made {:type => :usa_ssn} deprecated for SSN validation, because such additional logic is overhead because I don't know countries with same identification name (ssn). I think that we need to have this deprecation message at least for one release and then I'll finally remove the code which'll make code cleaner.

franckverrot commented 10 years ago

Good idea ! Thanks!

franckverrot commented 10 years ago

Do you mind updating the README and probably also update the gemspec to mention the deprecation?

Thanks again.

Loremaster commented 10 years ago

I suppose that I'll completely remove mention about {:type => :usa_ssn} from the Readme. What do you think about that? Is that ok?