search

francma / everforest-jetbrains

🌲 Everforest theme for JetBrains
ISC License
19 stars 4 forks source link

Hard coded colors and commented colors? #9

Open frere-jacques opened 1 year ago

frere-jacques commented 1 year ago

I saw that there are some hard coded colors within the theme by running: cat src/*.xml | grep value=\"[a-zA-Z0-9] and cat src/includes/*.xml | grep value=\"[a-zA-Z0-9]

Further I find out by running cat src/includes/*.xml | grep \# that there is a # infront of many colors in python file.

Since I am unsure whether this is intended or not I didn't provide a fix for it.

francma commented 1 year ago

It's not intended. All hardcoded colors should be replaced with $envs in the future.

frere-jacques commented 1 year ago

Good to know. I will see if I can fix some of it.