francma / wob

A lightweight overlay volume/backlight/progress/anything bar for Wayland.
ISC License
911 stars 50 forks source link

Prevent repeated crashes with socket activation #107

Closed Scrumplex closed 1 year ago

Scrumplex commented 1 year ago

If an application shoves invalid input into the socket, the following input might be invalid as well. systemd will, by default, send all pending input to the restarted process, in case the service crashed before. We don't really want that, as it might cause wob to crash yet again. Therefore, systemd should just flush/discard all pending data and move on.

francma commented 1 year ago

Thanks, looks good.

One little note: please reword it to not say "crash", use "exit on invalid input" or something along these lines. Also the line with the comment in service file seems to be broken:

 If wob crashes from an input systemd should NOT shove it right back into it after it resta>
Scrumplex commented 1 year ago

Done! Also updated the commit message

francma commented 1 year ago

Thanks :+1: