search

francma / wob

A lightweight overlay volume/backlight/progress/anything bar for Wayland.
ISC License
911 stars 50 forks source link

Implement timeout. #9

Closed 7415963987456321 closed 5 years ago

7415963987456321 commented 5 years ago

This commit implements the timeout feature such that a user can set the timeout of wob with a command line argument '-t [milliseconds]'. The arguments are parsed with a standard getopt loop, this comes in handy for future additions.

francma commented 5 years ago

I think it would be great to have it accept milliseconds instead of seconds. This way user can define intervals shorter than 1 sec :)

And also please try to make the code look like the rest of the file - space before opening ( and so on - thanks.

7415963987456321 commented 5 years ago

@francma Yeah, it makes more sense to have it accept milliseconds. I have addressed that as well as the style guide.

7415963987456321 commented 5 years ago

Eh something funky going on while resolving the merge conflicts, It should be fine now, except I keep getting that one commit that is 'Merge to master', Everything is correct though.

francma commented 5 years ago

Sorry for the delay :slightly_frowning_face:

I'm currently working on fixing https://github.com/francma/wob/issues/3 and this kind of conflicts with my changes (that struct timeval timeout part, getopt is fine). I'll get back to you once I'm done. Thanks :slightly_smiling_face:

7415963987456321 commented 5 years ago

Alright, do you mind if I expand on this a little bit. I have a branch implementing a version flag, and I've finished the maximum feature. I might just push all those features into this branch if you don't mind.

Unless you want me to open separate pull rrquests for those.

francma commented 5 years ago

Create 1 PR per 1 feature, preferably.