search

francogarcia / godot-gdscript.el

Major mode for editing Godot Engine GDScript files with Emacs.
GNU General Public License v3.0
51 stars 9 forks source link

Add missing multiplayer keywords #4

Closed tavurth closed 5 years ago

tavurth commented 5 years ago

After working through the multiplayer tutorial it seems like some of the gdscript keywords specific to multiplayer are missing.

This PR fixes the issue, although I'm not sure if this is the correct way to go about it?

image

francogarcia commented 5 years ago

Hello, @tavurth , How are you?

Thank you for your contribution!

block-start forces an indentation on the following line. In this case, as it precedes the func keyword, it might not be necessary (however, I would have to check to be sure). There is no harm leaving it there, though. If you notice double indentation at the next line, it is just a matter of removing it afterwards.

GDScript has evolved considerably last year. For instance, there are the optional types now (for variables and function definitions).

If you have noticed anything that is currently missing, please tell me. I will try to address them when I have time.

Best regards, Franco

tavurth commented 5 years ago

I haven't seen a double indentation issue, think it just sets up the next line to be indented rather than adding an extra tab.

Actually the optional types seem to be working just fine!

I'll be playing around a bit over the next few weeks and if I see any issues I'll try to make a PR or at least an issue.

Thank you ☺️