search

francois-roseberry / monopoly-js

Javascript implementation of the Monopoly game
36 stars 14 forks source link

Sometimes, test hang in ci #24

Closed francois-roseberry closed 1 hour ago

francois-roseberry commented 1 day ago

The whole suite of unit test executes in a few seconds, yet sometimes (rarely, can't figure out why), it hangs after the tests, and I have to cancel the job and re-run it.

francois-roseberry commented 1 day ago

It hangs sometimes locally too

francois-roseberry commented 1 day ago

Seems like a game is running infinitely somewhere, I can see it in one random CI test error I got

francois-roseberry commented 1 hour ago

I've found the culprit. The LogGameTask test did not stop the game it started so it ran wild, and sometimes caused an error. I fixed the test, and it seems fine now