francoischalifour / medium-zoom

🔎🖼 A JavaScript library for zooming images like Medium
https://medium-zoom.francoischalifour.com
MIT License
3.58k stars 160 forks source link

fix mobile safari scale bug #172

Closed nabettu closed 3 years ago

nabettu commented 3 years ago

Summary

fixed this issue on mobile safari zoomed image blurry. #151 https://github.com/francoischalifour/medium-zoom/issues/151

Result

It does not use "transform scale" but instead sets width and height.

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d630673b53c26e66711e0a3753996f554deca9a:

Sandbox Source
@medium-zoom/vanilla-example Configuration
nabettu commented 3 years ago

@francoischalifour OK. Thanks for considering this PR! The best thing is that safari itself solves this issue, so wait for it.

flekschas commented 3 years ago

Too bad this doesn't get addressed. Thanks for the work anyway!

The best thing is that safari itself solves this issue, so wait for it.

Do you mind elaborating? :) Is a new version of Safari going to fix this? I am curious because currently this library not useful for iOS given the bug.

AdrianFahrbach commented 1 month ago

@francoischalifour Any updates on this? It is still an open issue (#151) and makes this package unusable for my use cases.

Maybe only applying this fix on Safari browsers as a fallback would be a solution? I get your efficiency doubts, but we are talking about a single, short animation, so I think this shouldn't lead to performance issues.