search

francoischalifour / medium-zoom

🔎🖼 A JavaScript library for zooming images like Medium
https://medium-zoom.francoischalifour.com
MIT License
3.58k stars 160 forks source link

fix: remove `loading` attribute on HD target #186

Closed NYPD closed 2 years ago

NYPD commented 2 years ago

Summary

Fixes #185

Remove any loading attribute the zoomedHd cloned node might have to allow the browser to load it normally

Result

Same zoom behavior as expected. Before it used to glitch half the time and get stuck on a zoomed image and making the webpage unresponsive. The #185 ticket explains it.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 84e6f54297a94ceeaee8b235f1be75014781dcab:

Sandbox Source
@medium-zoom/vanilla-example Configuration
@medium-zoom/vanilla-example Issue #185
cool-forest-yvlu0h Issue #185
crutchcorn commented 1 year ago

@francoischalifour any chance for an NPM release? This is a blocker on adding in medium-zoom back to my site

francoischalifour commented 1 year ago

🎉 I just released v1.0.7 which includes this fix.