search

francoischalifour / medium-zoom

🔎🖼 A JavaScript library for zooming images like Medium
https://medium-zoom.francoischalifour.com
MIT License
3.58k stars 161 forks source link

style: `.png` This kind of transparent image will affect the reading … #187

Closed lecepin closed 1 year ago

lecepin commented 2 years ago

Summary

.png This kind of transparent image will affect the reading after opening.

before:

image

Result

now:

image

Can you help with Code Review? @francoischalifour thanks.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 535f72d36f9eaa2ccd2ba9f2a4283453b136734b:

Sandbox Source
@medium-zoom/vanilla-example Configuration
francoischalifour commented 2 years ago

Thank you for your contribution.

This is a good CSS addition to have in your CSS, but I don't think we can assume that all transparent PNG images will look good with a white background?

lecepin commented 2 years ago

Thank you for your contribution.

This is a good CSS addition to have in your CSS, but I don't think we can assume that all transparent PNG images will look good with a white background?

Add the zoomedBackground property to set the background of the zoomed image, Not sure if this is possible? @francoischalifour thanks.