search

francoischalifour / medium-zoom

🔎🖼 A JavaScript library for zooming images like Medium
https://medium-zoom.francoischalifour.com
MIT License
3.58k stars 160 forks source link

invalid image (and possibly slow loading image) breaks behavior, gets trapped inside zoom #215

Open 719media opened 1 month ago

719media commented 1 month ago

Bug description

Medium zoom won't ever close if the image never loads. For example, dropped or slow connection. Troubleshooting further, this only happens when srcset is in use.

How to reproduce

  1. https://codesandbox.io/p/sandbox/sweet-jepsen-hc9n4f?file=%2Findex.html%3A23%2C1
  2. Contract clicking on the first invalid image vs. the second. The first "doesn't work" (can't close after open, and doesn't animate), and the second works.