Fixed IE10/11 support (#34)

francoischalifour / medium-zoom

🔎🖼 A JavaScript library for zooming images like Medium

https://medium-zoom.francoischalifour.com

MIT License

3.59k stars 164 forks source link

Fixed IE10/11 support (#34) #35

Closed jhildenbiddle closed 6 years ago

jhildenbiddle commented 6 years ago

Changed NodeList-to-Array conversion from spread operator to Array.apply
Changed Array.includes instances with Array.indexOf
Changed ES6 code in demo.js to ES5 as this code is not transpiled via babel
Added CustomEvent polyfill and converted dispatched Event() instances to CustomEvent()

francoischalifour commented 6 years ago

As for template support, we can link towards one of these solutions:

I don't have the tools to test these solutions on IE unfortunately.

jhildenbiddle commented 6 years ago

If interested, head over to https://www.browserstack.com and sign up for a free open-source developer account. This will make testing in IE much, much easier. The Chrome extension makes any OS/browser combination just a few clicks away.

You can also get a free open-source account on http://saucelabs.com. Same general idea. Both offer live testing in your browser as well as automated testing. I use both (SauceLabs for automated testing, BrowserStack for live testing).

Hope this helps!

francoischalifour commented 6 years ago

Thanks for all the tips, that will definitely be useful!

jhildenbiddle commented 6 years ago

Apologies for the delay on the update.

The polyfill that was previously included has been removed. In its place is a custom ZoomEvent function which does essentially the same thing (creates modern+legacy compatible CustomEvents) without modifying the window object.

Preview

I did not dive into <template> support, but I can confirm that the combination of this PR + template-element-polyfill allowed the demo, dropbox-paper-template, and facebook-template pages in the repo to function properly on IE10/11. It would be nice if template support for IE was provided without the need for a polyfill, but that was beyond the scope of this PR.

If this PR is merged, I will make sure the maintainers of docsify are notified so that they can update their zoom-image plugin.

Thanks!

jhildenbiddle commented 6 years ago

No worries at all. Happy to land this. :)

francoischalifour commented 6 years ago

We need to add the "Support" section in the README and then we're good to release a new version of the library! I'll do that by the end of next week. Thanks a lot!