search

francoisfds / BikeSharingHub

Shared bikes for Android
GNU General Public License v3.0
18 stars 10 forks source link

Attribution #24

Open danieldegroot2 opened 2 years ago

danieldegroot2 commented 2 years ago

Hey francois,

I saw a screenshot and the screenshots on the f-droid store; I found the OpenStreetMap attribution to be lacking a link ( https://www.openstreetmap.org/copyright ) at the word "OpenStreetMap" and the map objects are being displayed on top of the attribution, as well as possibly having other map styles available as well, for which the attribution could be similarly lacking (I can not check this).

Could you have a look at this, please?

francoisfds commented 2 years ago

Hello. Thank you for reporting this issue. I've added the copyright notice using a built-in API but I will try to customize it to comply with the requirements. I am a regular OSM contributor and love OSM project, so I will do my best.

Regards.

Altonss commented 2 years ago

I think the attribution is really good and sufficient now, so we could close the issue. What do you think?

francoisfds commented 2 years ago

Actually, the attribution does not match all the requirements yet. It still lacks the hypertext link, which is not embedded in osmdroid I think.

francoisfds commented 2 years ago

Afrer verification, the page https://www.openstreetmap.org/copyright/en states :

you may link to this copyright page

Which does not mean "you must". So you are right @Altonss the attribution is sufficient. If it is possible it would be better to add the link so I keep the issue openned a little bit longer, but this is not a priority.

danieldegroot2 commented 2 years ago

From the Attribution Guidelines

1.3-5

There needs to be a way to access more information, including origin and licence of the data, if that information is not directly in the attribution text (for example by making the text a clickable link).

From the Copyright page, same section as before

In media where links are not possible (e.g. printed works), we suggest you direct your readers to openstreetmap.org (perhaps by expanding 'OpenStreetMap' to this full address) and to opendatacommons.org.

PS: Could you include a screenshot (of both versions) with proper attribution in this issue, please? This way people can easily see what you intend to display to the user (and make sure it is displaying as such).