francoisfds / BikeSharingHub

Shared bikes for Android
GNU General Public License v3.0
18 stars 10 forks source link

Themed icon support for Android 13 #39

Closed Altonss closed 1 year ago

Altonss commented 2 years ago

I haven't tested if it works and how it renders, so this is only a first try :) Also @francoisfds what do you think about switching to vector graphics for the icons like in https://github.com/CatimaLoyalty/Android/pull/987/files ?

francoisfds commented 2 years ago

Hello @Altonss thank you for the contribution.

I cannot test these changes on Android 13 right now but I will soon !

For the record I designed vector graphics already (https://github.com/francoisfds/BikeSharingHub/commit/a6f4e415aace65a32f49f5c78537aa21431baf45) which are in the current release 2.0.6. But you have reported an issue with them : https://github.com/francoisfds/BikeSharingHub/issues/6#issuecomment-1079669562

To avoid this issue, I recently split icons depending on the Android version, to create adaptive icons but I switch back to PNGs. It's true that using the vectorised form is better.

Altonss commented 2 years ago

To avoid this issue, I recently split icons depending on the Android version, to create adaptive icons but I switch back to PNGs. It's true that using the vectorised form is better.

Do you know why PNGs are used for the adaptive icons, is it because of #6 ?

francoisfds commented 2 years ago

Yes I switched back to PNGs because of #6.

francoisfds commented 1 year ago

Tested on Android 13, the icon is well displayed when themed icons are enforced :+1: I merge, thank you @Altonss