Mark closed or in maintenance stations as closed in more networks

[sbssk8]

Hi! The way stations are marked as closed on the network I'm using wasn't handled on BikeSharingHub. I've tried to find all the possible options to specify this for all networks on CityBikes API.

Let me know if anything would need to be changed to get it merged!

Many thanks, Sebastià

[francoisfds]

Hello, thank you very much for you contribution ! Before merging, can you share the name of one (or more) network which is concerned please ? It's just to check the behaviour.

[sbssk8]

Sure!

I tried to cover all the possible cases, these are the networks I believe got the closed station improvement with this pull request

for PLANNED bicincitta-agglo-fribourg bicincitta-lausanne-campus-morges bicincitta-trieste mobike

for UNDER CONSTRUCTION bicincitta-forli bicincitta-monza bicincitta-trieste e-motion-trento parma relay-atlanta terni to-bike

for EN MAINTENANCE vlille

for MAINTENANCE bicincitta-livorno ciclopi gimme-bike goodbike parma saclay-captainbike terni to-bike

for IMPLEMENTATION bikepetrolina

for online:false bicimad bicing bicipalma bikemi le-velo-star onroll-a-rua onroll-albacete onroll-alhama-de-murcia onroll-almunecar onroll-antequera onroll-aranda-de-duero onroll-aranjuez onroll-badajoz onroll-baeza onroll-benidorm onroll-blanca onroll-cieza onroll-don-benito-villanueva onroll-el-campello onroll-elche onroll-guadalajara onroll-jaen onroll-lalin onroll-las-palmas onroll-montilla onroll-mula onroll-novelda onroll-paiporta onroll-palencia onroll-pinto onroll-priego-de-cordoba onroll-puerto-lumbreras onroll-puertollano onroll-redondela onroll-salamanca onroll-san-javier onroll-san-pedro onroll-sant-joan onroll-segovia onroll-soria onroll-talavera onroll-ubeda onroll-universidad-de-granada onroll-via-verde onroll-villaquilambre onroll-vinaros v3-bordeaux vel-in velobleu vlille

for installed":false I didn't find any... But santander-cycles has installed:true

[sbssk8]

Just marked as draft becasue for the onroll ones I've found that most of them have all the stations marked as closed. And I'm not sure it they should be

Will check tomorrow (or soon) and get back to you!

[sbssk8]

Hey @francoisfds ! The last updates I've found on the internet about onroll networks are from ~2009... Maybe they are actually closed?

Also, about santander-cycles, I'm not sure it makes sense to have the check. Should it be removed before merging? There's removalDate which is empty for all the stations but one, maybe that's the way to go for this network? (This removalDate field is only used on this network anyway...)

[sbssk8]

Marking back as ready to review!

I tried to call to domoblue (the company behind onroll systems) to ask it they had any of the networks available and it seems like the phone number doesn't exist anymore... After further checking, it seems like the company faced bankruptcy source (In Spanish) back in 2019...

Anyway, I'm just letting pybikes know on https://github.com/eskerda/pybikes/issues/202

[francoisfds]

Hello @sbssk8, and thanks for taking the time to call the company for onroll networks. That’s OK with the online field, then.

For santender-cycles the purpose of the extra.installed value is not clear (neither the extra.locked, which we use already as I see it). The company maintains a list of "Suspended docking stations" on this page : https://tfl.gov.uk/modes/cycling/santander-cycles/docking-stations but those stations are not on the feed. The removalDate extra field does not seem to be usefull because the only station using it is actually in service (according to the above website). Thus, I think we can remove the extra condition for installed, what do you think ?

[francoisfds]

Well finaly I think we can keep matching for installed field as it could be usefull. Thank you again for your contribution @sbssk8 !

[sbssk8]

Great! Thanks for integrating the changes! (And sorry for the late reply)