search

francoisfds / BikeSharingHub

Shared bikes for Android
GNU General Public License v3.0
18 stars 10 forks source link

Icon not displaying well on Samsung Galaxy A40 #6

Closed Altonss closed 1 year ago

Altonss commented 2 years ago

With the Samsung OneUI desing the icon doesn't render well. This is just a minor issue, but maybe it would not be too difficult to tweak the icon for these devices? This is not a priority, but just a cosmetic detail that could make the app more appealing to new users :) image

Altonss commented 2 years ago

I know where this issue might come from: Adaptive icons https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive. Especially for newer devices we should target this compatibility :)

francoisfds commented 2 years ago

Unfortunately Adaptive Icons start from SDK 26 and we are 23 for now (there is a bug left before upgrading). In the meantime, I think that just having the same icon without any border could do the job. On this Samsung it’s already a good thing that there is no grey/blank background behind the icon.

Altonss commented 2 years ago

Unfortunately Adaptive Icons start from SDK 26 and we are 23 for now (there is a bug left before upgrading).

Where is the bug located/what is it about?

francoisfds commented 2 years ago

It occurs when the map is opened. Something is not handled well and an exception is thrown. I don't remember exactly why but you can see a log on the current release. Starting from SDK 24 it turns into a crash.

Altonss commented 2 years ago

Thanks for the update! The icon is displaying a little bit pixelated in my F-Droid app, is this also happening to you? And on my android home screen as well, I don't know if it's Android 5 messing up the icon...

francoisfds commented 2 years ago

I use Android 10 and icon is OK on my home screen. But I tested on an Android 5.1.1, Samsung (screenshots bellow) and it's OK too both home screen and F-Droid icon. However the banner is pixelated like it was before.

Screenshot_homescreen Screenshot_fdroidclient

May be your problem is due to the fact that icons are vectorized now.

What is the behaviour for Samsung Galaxy A40 ?

Altonss commented 2 years ago

I don't have the Galaxy A40 right now, but I soon as I can test it I will give my feedback. Here is my screenshot of F-Droid: image

Here my screenshot on Android 5: (here compared to Catima) image

These issues might be related to my device (and my older version of F-Droid), so don't worry :)

francoisfds commented 2 years ago

Thanks for the update! The icon is displaying a little bit pixelated in my F-Droid app, is this also happening to you? And on my android home screen as well, I don't know if it's Android 5 messing up the icon...

Since release 2.0.6 the icon in F-Droid must be OK, isn't it ? It was written in the docs that "the app icon is mandatory if your app doesn't include any png icon" (https://f-droid.org/docs/All_About_Descriptions_Graphics_and_Screenshots). So new there is a PNG icon in the fastlane directory : https://github.com/francoisfds/BikeSharingHub/blob/master/fastlane/metadata/android/en-US/images/icon.png

As for the launcher icon, we will put PNG icon back for Android version < 8.0.0 and keep going with vectorized form for recent Android.

Altonss commented 2 years ago

Since release 2.0.6 the icon in F-Droid must be OK, isn't it ?

Looks good on my device :ok_hand:

Altonss commented 1 year ago

Everything is fine now, thank you :)