francoisjacquet / rosariosis

RosarioSIS Student Information System for school management.
https://www.rosariosis.org
GNU General Public License v2.0
526 stars 349 forks source link

Search.fnc.php performs wrong query #270

Closed dzungdo closed 4 years ago

dzungdo commented 4 years ago

Select: Menu > Users > Associate Students with Parents This bring up a search page, One of the preconfigured field is "Email Address" - this searches correctly.

I have a custom field named "Phone", with type of "Text"

When search, the result failed to find anything. Because Search is searching for "custEmail"

francoisjacquet commented 4 years ago

Hello @dzungdo

I was not able to reproduce the issue: image

image

image

Please provide screenshots or a video which clearly shows the issue.

dzungdo commented 4 years ago

In my case, I can reproduce it every time.

  1. Select "Associate Students with Parents" image

  2. image

  3. image

  4. image

I am using 7.2.2

dzungdo commented 4 years ago

Inspecting HTML codes on two different pages:

Associate Parents with Students Student Email

<tr class="">
   <td><label for="custCUSTOM_200000015">Student Email</label></td>
   <td><input type="text" name="cust[CUSTOM_200000015]" id="custCUSTOM_200000015" size="24" maxlength="1000"></td>
</tr>

Student Mobile Number:

<tr class="">
   <td><label for="custCUSTOM_200000016">Student Mobile Number</label></td>
   <td><input type="text" name="cust[CUSTOM_200000016]" id="custCUSTOM_200000016" size="24" maxlength="1000"></td>
</tr>

Associate Students with Parents User Email:

<tr class="">
   <td><label for="custEMAIL">Email Address</label></td>
   <td><input type="text" name="cust[EMAIL]" id="custEMAIL" size="24" maxlength="1000"></td>
</tr>

User Mobile Number: (This is a different custom field but same content)

<tr class="">
   <td><label for="custEMAIL">Mobile Number</label></td>
   <td><input type="text" name="cust[EMAIL]" id="custEMAIL" size="24" maxlength="1000"></td>
</tr>

Should cust[EMAIL] be something like cust[CUSTOM_200000001] ?

francoisjacquet commented 4 years ago

Hello @dzungdo

Thank you for the screenshots. The issue is fixed. Please upgrade to v7.2.3