search

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

Added the ability to be generate binding for sql.Nulls. #100

Closed OGKevin closed 5 years ago

OGKevin commented 5 years ago

Fixes #99

This PR adds the ability for the generator to generate the sql.Null fields.

codecov-io commented 5 years ago

Codecov Report

Merging #100 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #100   +/-   ##
======================================
  Coverage    98.7%   98.7%           
======================================
  Files          36      36           
  Lines        5189    5189           
======================================
  Hits         5122    5122           
  Misses         52      52           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90d9533...9749086. Read the comment docs.

OGKevin commented 5 years ago

I take it that this one can be close due to #101 ? a heads up or feedback would be appreciated :)

francoispqt commented 5 years ago

Hi, yes you are right. The new generator is much better in design and handles much more cases. Your PR was good but not needed anymore.

Let me know if you have issues with the new generator and sorry for the late answer :)