search

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

Streaming decoder hung #114

Closed n3integration closed 5 years ago

n3integration commented 5 years ago

First, thank you for your work on gojay. I am seeing a 2-3x performance improvement over the standard library.

I encountered what I thought was a deadlock in the streaming decoder, but after further debugging I found that the process was not hung. Instead, the buffer size had been reduced to zero, which brought the streaming decoder to a screeching halt. I was going to submit a pull request, but noticed e5b786c9100c29947ac368300c0fe0dacc00c695 in the list of commits.

When using go modules, the broken version is the version that all new projects will pull in as a dependency. Any chance a new release could be built to prevent others from running into this issue?

francoispqt commented 5 years ago

Hi, sorry for the delay, I've been very busy lately.

I will push an update of the go modules.

n3integration commented 5 years ago

No worries. Thank you, sir.

francoispqt commented 5 years ago

Dependencies have been fixed with #117

I'm closing the issue. Please ask to reopen if it doesn't work.

Cheers