search

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

Improve performance of `skipNumber` by reducing branching #37

Closed luismfonseca closed 6 years ago

luismfonseca commented 6 years ago

Not the most readable code, but it seems to run benchmarks about ~5% faster.

francoispqt commented 6 years ago

Will wait for CI to run and merge this. Thanks

codecov-io commented 6 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #37   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     30           
  Lines        3403   3403           
=====================================
  Hits         3403   3403
Impacted Files Coverage Δ
decode_number.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3ffafe...009e556. Read the comment docs.

francoispqt commented 6 years ago

Merged, sorry for the delay